search

fawazahmed0 / quran-api

Free Quran API Service with 90+ different languages and 400+ translations
The Unlicense
630 stars 113 forks source link

Danish translation is actually Dutch #48

Closed 0x1eef closed 2 months ago

0x1eef commented 1 year ago

The dan-vandetaal translation is not Danish but Dutch - as far as I can tell. Should it be stored as nld-vandetaal instead ?

fawazahmed0 commented 1 year ago

Thanks, will take a look.

Should it be stored as nld-vandetaal instead ?

Yes, I will have to create nld-vandetaal while still keeping the dan-vandetaal edition

0x1eef commented 1 year ago

Thanks for the quick reply.

Yes, I will have to create nld-vandetaal while still keeping the dan-vandetaal edition

I understand that makes sense from the perspective of an API version, but it might be misleading to those who assume the language is Danish. Maybe it is a good reason to have v1.1 of the API where the issue can be addressed by removing dan-vandetaal.

fawazahmed0 commented 1 year ago

The translation is available in nld-unknown. I have updated the author name without changing the link

0x1eef commented 1 year ago

Alright :+1: Welcome to close if that resolves it.

0x1eef commented 2 months ago

Hey :wave: I'm looking at my issue list. Can we close this one ?

fawazahmed0 commented 2 months ago

Jazakallah! for informing