Improve error handling - Githubissues

fawick / go-mapnik

Go bindings for mapnik (http://www.mapnik.org or http://github.com/mapnik/mapnik)

BSD 3-Clause "New" or "Revised" License

60 stars 18 forks source link

Improve error handling #3

Closed olt closed 10 years ago

olt commented 10 years ago

I tried to improve the error handling by adding error as a return value for most functions. It requires mapnik_map_last_error see: https://github.com/springmeyer/mapnik-c-api/pull/5

It's still a work in progress:

[ ] mapnik_map_last_error needs to be merged in mapnik-c-api
[ ] errors in the RegisterXXX functions should be handled as well
[ ] add tests

fawick commented 10 years ago

Thank you for your contribution! I'll be happy to merge the pull request once @springmeyer has accepted springmeyer/mapnik-c-api#5 as go-mapnik is probably not building without these changes to mapnik-c-api.

And I look forward to any updates of the upper todo list! :-)

springmeyer commented 10 years ago

springmeyer/mapnik-c-api#5 is now merged.

fawick commented 10 years ago

Thanks @springmeyer !