search

fay59 / fcd

An optimizing decompiler
http://zneak.github.io/fcd
Other
705 stars 70 forks source link

reserved identifier violation #10

Closed elfring closed 8 years ago

elfring commented 8 years ago

I would like to point out that identifiers like "fcd__metadata_h" and "fcd__targetinfo_h" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

fay59 commented 8 years ago

Pragmatically, I'm not particularly worried that any of these are ever going to conflict with anything and I don't plan on changing it. I probably wouldn't reject a PR that does it though.

elfring commented 8 years ago

How do you think about to avoid that this software depends on undefined behaviour?

fay59 commented 8 years ago

I'll change it myself if you can find a single C++14 compiler where this actually matters. I'll still take PRs if they come my way.

Trass3r commented 8 years ago

Nowadays every big compiler supports #pragma once anyway, which does away with the whole problem.

elfring commented 8 years ago

Do you care for standard compliance?

fay59 commented 8 years ago

I care about and work for things that have a practical impact. I prefer compliance over non-compliance and I'm careful about UB when it can actually break the program, but I'm not interested in spending any of my own time to do things that have no practical value.

Your time would be better spent actually fixing this issue or finding bugs that are actually caused by UB rather than discussing this particular instance.