fayaz12g / totk-aar

Any Aspect Ratio for Tears of the Kingdom! A tool to generate custom settings to make the game look great on any display!
106 stars 5 forks source link

Tool Only Runs on Windows (not Linux or macOS) #22

Closed wherron01 closed 1 year ago

wherron01 commented 1 year ago

As this is all Python, could it be made cross-platform and a Linux build shipped? I'd really like to use this mod tool, but I don't have a Windows install.

morceaudebois commented 1 year ago

Same for Mac.

notoriousjere commented 1 year ago

given you have python 3.11 and all of the packages used in the project, you could just run python3 GUI.py on either of those platforms and it should work

wherron01 commented 1 year ago

This fails with the following error

Traceback (most recent call last):
  File "/home/user/totk-aar/script.py", line 21, in <module>
    file_names = os.listdir(blyt_folder)
                 ^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/user/totk-aar/AAR MOD/temp/Common.Product.110.Nin_NX_NVN/blyt'
Exception in thread Thread-4 (create_full):
Traceback (most recent call last):
  File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.11/threading.py", line 975, in run
    self._target(*self._args, **self._kwargs)
  File "/home/willow/totk-aar/GUI.py", line 168, in create_full
    os.remove(blarc_file_path)
FileNotFoundError: [Errno 2] No such file or directory: '/home/user/totk-aar/AAR MOD/temp/Common.Product.110.Nin_NX_NVN.blarc'
wherron01 commented 1 year ago

I traced the issue back to the zstandard python package. The one packaged with the mod tool does not work, and I already had the zstandard package on my install, but it defaulted to the one packaged. Renaming it to zstandard-backup let the tool use my system package, which worked.

notoriousjere commented 1 year ago

There should really be a version of this project that uses poetry to manage a virtual environment that grabs the necessary dependencies instead of including them in the repo

fayaz12g commented 1 year ago

Currently when I use it on mac i use parallels, I know this is not preferred than running natively, especially as it is a UNIX based OS with Python already installed. I will likely release an appimage eventually that does the same thing, but works on macOS/steamOS/Linux. Unsure why the zstandard dependencies packed in are only working on windows.

wherron01 commented 1 year ago

Just for the record, I later discovered that the generated mod wasn’t working, despite the tool not throwing any errors, and that this was because the same thing was happening with the keystone package as was with the zstandard package.

fayaz12g commented 1 year ago

I appreciate you updating me with that. It seems this tool does not like to work with any operating system other than windows at the moment. I'll work to fix it as a stretch goal

dcbishop commented 1 year ago

It works using Wine

Samueru-sama commented 1 year ago

It works using Wine

How do you use this with wine? The program opens and I can input the parameters, but when I hit generate nothing happens.

fayaz12g commented 1 year ago

@Samueru-sama Did you specify the output folder to where you want it to go?