search

fayaz12g / totk-aar

Any Aspect Ratio for Tears of the Kingdom! A tool to generate custom settings to make the game look great on any display!
106 stars 5 forks source link

Script is calling python externally for all files instead of running them directly #5

Closed crudelios closed 1 year ago

crudelios commented 1 year ago

Hello,

There seems to be a slight issue with the script, which may be causing problems to some users.

It seems you bundled everything as an executable. However, inside your main pyrhon scripts bundled in the executable, you're calling python directly for the sub-scripts (like download.py), which requires users to manually install python on top of your executable. In turn, that seems to require the proper dependencies to be installed regardless of them being bundled in the exe.

I don't know enough about python to provide an alternative to your approach, but maybe a simple thing like import download would work? That would at least prevent people from having to install python, while also avoiding dll conflicts.

fayaz12g commented 1 year ago

Hey! You are absolutely correct, I can change the way the python files are called, rather than opening them in python, I could import it as a subprocess and call the function itself instead of running the file to avoid the DLL conflict/need for python 3.11 installed. I will make these changes in a future version, but I am away from home this weekend

fayaz12g commented 1 year ago

This should be fixed now