search

faye / faye-redis-ruby

Redis engine backend for Faye
80 stars 38 forks source link

Support new em-hiredis v0.2.0 #6

Closed le0pard closed 11 years ago

le0pard commented 11 years ago

Support new em-hiredis v0.2.0:

https://github.com/mloughran/em-hiredis/blob/master/CHANGELOG.md#020-2013-04-05

jcoglan commented 11 years ago

Thanks! I was talking to the em-hiredis maintainer just last night about this and this looks good.

Can you remove all the whitespace changes?

le0pard commented 11 years ago

Hello. Yes, sorry about this, it done by my editor automatically.

jcoglan commented 11 years ago

Since picking up git I've been removing all whitespace from projects to avoid this sort of thing, but it's much better if done in dedicated commits.

jcoglan commented 11 years ago

s/git/vim/

le0pard commented 11 years ago

Done

jcoglan commented 11 years ago

Sorry, I mean submit commits that don't contain any whitespace changes. The problem is having commits that contain both code and formatting changes, so your second commit doesn't solve this problem.

jcoglan commented 11 years ago

If it makes things easier, I could push a commit to get rid of all the whitespace, then you can push changes on top of that?

le0pard commented 11 years ago

Back all whitespaces, only my changes in this commit.

jcoglan commented 11 years ago

Does it work with em-hiredis 0.1.0? If not, can you bump the dependency in the gemspec?

le0pard commented 11 years ago

Done

le0pard commented 11 years ago

Thanks :+1:

jcoglan commented 11 years ago

Thank you :)