search

fayeed / flutter_mentions

A simple flutter input widget to add @ mentions functionality to your app
MIT License
107 stars 122 forks source link

Support for flutter 1.22.0 #18

Closed krishnakumarcn closed 4 years ago

krishnakumarcn commented 4 years ago

Portal dependencies changed

fayeed commented 4 years ago

@krishnakumarcn Can you explain whats it the PR for, in brief Thanks!

krishnakumarcn commented 4 years ago

The previous version of flutter_mentions i.e., 1.0.1 is not working with flutter version 1.22.0. I could see that the flutter_portal dependency in the version 1.0.1 is not updated to the latest portal version which is 0.3.0 which is updated specifically to support flutter 1.22.0.

So that's the only change.

fayeed commented 4 years ago

Yeah so can you create a new PR with that change alone that would be great.

krishnakumarcn commented 4 years ago

The previous version of flutter_mentions i.e., 1.0.1 is not working with flutter version 1.22.0. I could see that the flutter_portal dependency in the version 1.0.1 is not updated to the latest portal version which is 0.3.0 which is updated specifically to support flutter 1.22.0.

So that's the only change.

Also you could look into that issue more if you are seeing anything else with flutter 1.22.0, but when I simply changed the portal version it fixed.

krishnakumarcn commented 4 years ago

Effectively this PR only contains that change along with the Flutter 1.22.0 changes to the pubspec.lock file. Could u check on the files changed tab?

fayeed commented 4 years ago

@krishnakumarcn Thanks for the PR