fayland / perl-Dist-Zilla-Plugin-GitHubREADME-Badge

Dist::Zilla - add badges to github README.md
Other
6 stars 9 forks source link

Add missing prereqs to match use #20

Closed paultcochrane closed 8 years ago

paultcochrane commented 8 years ago

The kwalitee tests on CPANTS show that some modules are used but not declared as prerequisites. This change brings code up to date and thus closes the prereq_matches_use CPANTS core issue for this distribution.

If anything needs changing in this PR, please just let me know and I'll update it appropriately and resubmit.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 99.412% when pulling 6765dd3981e40a2b39c538f43d03c4148ffb106e on paultcochrane:pr/add-missing-prereqs into bdd91252732b952fdc14e3fda4d209696d5b52ed on fayland:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 99.412% when pulling 6765dd3981e40a2b39c538f43d03c4148ffb106e on paultcochrane:pr/add-missing-prereqs into bdd91252732b952fdc14e3fda4d209696d5b52ed on fayland:master.

codecov-io commented 8 years ago

Current coverage is 95.88% (diff: 100%)

Merging #20 into master will increase coverage by 2.48%

@@             master        #20   diff @@
==========================================
  Files            14         11     -3   
  Lines           197        170    -27   
  Methods           0          0          
  Messages          0          0          
  Branches         26         17     -9   
==========================================
- Hits            184        163    -21   
  Misses            1          1          
+ Partials         12          6     -6   

Powered by Codecov. Last update 30727f0...6765dd3

paultcochrane commented 8 years ago

After having fixed the merge conflicts locally, something still seems to be wrong here as GitHub is still saying that the branch has conflicts WRT master. I'll close this as unresolved and submit a new PR.