search

fayland / perl-Dist-Zilla-Plugin-GitHubREADME-Badge

Dist::Zilla - add badges to github README.md
Other
6 stars 9 forks source link

Make PhaseReadme test package a package #28

Closed paultcochrane closed 7 years ago

paultcochrane commented 8 years ago

... at least as far as Perl::Critic is concerned. In Perl::Critic at severity level 4, the package declaration isn't found. The solution was to move the strict and warnings pragmas below the package declaration, hence silencing the Perl::Critic warning. The tests still pass, so the intended behaviour seems to be the same.

paultcochrane commented 8 years ago

Beyond this commit, most of the Perl::Critic issues start to become overly pedantic, and I don't think they bring much value for the code changes required (e.g. add missing return statements, unpack @_ in subs, etc). In fact, changing some of the code would make it less clearer by making Perl::Critic happy.

The code looks great! I hope my (somewhat picky) changes have been of use!

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.02%) to 99.474% when pulling 2d61f87cc121979cfd71ed5ca2f118490e81e44e on paultcochrane:pr/make-test-package-a-package into 7d29212a39035ea913e279967686cec76ee8266d on fayland:master.

codecov-io commented 8 years ago

Current coverage is 93.40% (diff: 100%)

Merging #28 into master will not change coverage

@@             master        #28   diff @@
==========================================
  Files            14         14          
  Lines           197        197          
  Methods           0          0          
  Messages          0          0          
  Branches         26         26          
==========================================
  Hits            184        184          
  Misses            1          1          
  Partials         12         12

Powered by Codecov. Last update 7d29212...2d61f87