Update Badge.pm - Githubissues

fayland / perl-Dist-Zilla-Plugin-GitHubREADME-Badge

Dist::Zilla - add badges to github README.md

Other

6 stars 10 forks source link

Update Badge.pm #8

Closed mishin closed 9 years ago

mishin commented 9 years ago

Hi, Fayland I add 3 badges

'github_tag' will be working ok, but 'license' and 'version' need cpan distribution name but usually $repository_name is not equal to cpan distribution name so I want just distribution name, how I can get it? or parse from git, any ideas? thanks

coveralls commented 9 years ago

Coverage decreased (-2.54%) to 61.84% when pulling bdf0bdc444f578640e8c91e5e916e8ce0c77edd9 on mishin:master into bf8bb47242bbbe3871ca9e69212d698fa6e7ab57 on fayland:master.

coveralls commented 9 years ago

Coverage decreased (-5.81%) to 58.57% when pulling bdf0bdc444f578640e8c91e5e916e8ce0c77edd9 on mishin:master into bf8bb47242bbbe3871ca9e69212d698fa6e7ab57 on fayland:master.

mishin commented 9 years ago

Hi, Fayland, I add $cpan_dist_name=$distmeta->{name}; it must works!

coveralls commented 9 years ago

Coverage decreased (-4.13%) to 60.26% when pulling c6f86113ece01ef6192b56f952d6f9023511b0eb on mishin:master into bf8bb47242bbbe3871ca9e69212d698fa6e7ab57 on fayland:master.

coveralls commented 9 years ago

Coverage decreased (-4.13%) to 60.26% when pulling c6f86113ece01ef6192b56f952d6f9023511b0eb on mishin:master into bf8bb47242bbbe3871ca9e69212d698fa6e7ab57 on fayland:master.

fayland commented 9 years ago

I think that's dist_name I provided.

https://github.com/fayland/perl-Dist-Zilla-Plugin-GitHubREADME-Badge/blob/master/lib/Dist/Zilla/Plugin/GitHubREADME/Badge.pm#L27

can you verify?

Thanks

mishin commented 9 years ago

Fayland , yes, it's more strait way, thanks

mishin commented 9 years ago

Well, I correct according your changes

coveralls commented 9 years ago

Coverage decreased (-2.54%) to 61.84% when pulling 5a29909f39bc266990a1500a49348ee3c103413d on mishin:master into bf8bb47242bbbe3871ca9e69212d698fa6e7ab57 on fayland:master.