search

faylang / fay

A proper subset of Haskell that compiles to JavaScript
https://github.com/faylang/fay/wiki
BSD 3-Clause "New" or "Revised" License
1.29k stars 86 forks source link

works with lts-10-1 and new traverse-with-class #449

Closed henrylaxen closed 6 years ago

henrylaxen commented 6 years ago

Hi Adam, Happy New Year. I hope this is helpful. I wish I could say I understood how fay works, but I figured out enough of the new traverse-with-class to get it to work with your code. All the tests run okay.
Best wishes, Henry Laxen

bergmark commented 6 years ago

I'll look into the travis build, I think it's just outdated and not directly related to these changes.

bergmark commented 6 years ago

I pushed a commit to your branch to change the GHC versions used on travis, looks like the newer traverse-with-class needs at least GHC 8.

henrylaxen commented 6 years ago

Sorry, I didn't understand the versioning, and I thought that lts-10-xx automatically pulled in GHC8. Yes, the newer traverse-with-class needs at least GHC 8. Glad to be helpful. I use fay all the time and really love it.

bergmark commented 6 years ago

No worries. I think it'll be easiest if I make the remaining small changes tonight, then I can explain them.

bergmark commented 6 years ago

There we go, I'll make a release shortly. Travis is very slow so the build times out, a future task could be to improve that.

Thanks again!