search

faylang / fay

A proper subset of Haskell that compiles to JavaScript
https://github.com/faylang/fay/wiki
BSD 3-Clause "New" or "Revised" License
1.29k stars 86 forks source link

getRuntime and getConfigRuntime disappeared #451

Closed maxigit closed 5 years ago

maxigit commented 6 years ago

getRuntime has disappeared as well as getConfigRuntime. This break yesod-fay module.

bergmark commented 6 years ago

Thanks for the report,

I forgot that this became part of the 0.24.0.0 release, dropping getRuntime does make some sense since you now get different results depending on if you are generating javascript or typescript.

Is it possible to update yesod-fay to use the new readConfigRuntime :: Config -> IO String? It should be a drop in replacement for getConfigRuntime

Either way, I t would be ok by me to add these functions again to remain backwards-compatible, they could be marked as deprecated. Would you be interested in sending a PR?

In the meantime you should be able to keep using yesod-fay with fay < 0.24

maxigit commented 6 years ago

I've tried but, replacing the call to getRunTime in yesod-fay by something or putting back getRunTime = this something in Fay should be equivalent. Unfortunately I didn't manage to do so. Also, fay doesn't work with the last version of GHC. I'm hoping to move the new version when this is fixed, so staying with fay < 0.24 is not ideal.

On 24 April 2018 at 22:10, Adam Bergmark notifications@github.com wrote:

Thanks for the report,

I forgot that this became part of the 0.24.0.0 release, dropping getRuntime does make some sense since you now get different results depending on if you are generating javascript or typescript.

Is it possible to update yesod-fay to use the new readConfigRuntime :: Config -> IO String? It should be a drop in replacement for getConfigRuntime

Either way, I t would be ok by me to add these functions again to remain backwards-compatible, they could be marked as deprecated. Would you be interested in sending a PR?

In the meantime you should be able to keep using yesod-fay with fay < 0.24

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/faylang/fay/issues/451#issuecomment-384081251, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHCiBBvoYixbuEc724cfZwAWpgknWYwks5tr5TggaJpZM4Tfg7x .

swamp-agr commented 5 years ago

Hi @maxigit, I could suggest to wait for fpco/yesod-fay#21 resolution.

maxigit commented 5 years ago

Brilliant. I didn't see it and it should indeed solve my problem.

On Tue, 16 Oct 2018 at 23:03, Andrey Prokopenko notifications@github.com wrote:

Hi @maxigit https://github.com/maxigit, I could suggest to wait for fpco/yesod-fay#21 https://github.com/fpco/yesod-fay/pull/21 resolution.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/faylang/fay/issues/451#issuecomment-430417201, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHCiL0dFkM_CEDj6WrmsyLpJSU9sf8gks5ullecgaJpZM4Tfg7x .

swamp-agr commented 5 years ago

@maxigit,

Actually, it was created a few days ago and merged some hours ago. As far as I see the changes had already been applied and present on Hackage as yesod-fay-0.9.0.

So, if it fixes your problem then you could close the issue!

Thanks, Andrey

maxigit commented 5 years ago

I've tried it yet, but I'll close the issue and reopen it if it doesn't solve the problem.

swamp-agr commented 5 years ago

Hi @maxigit,

Thanks! I have a project

And a couple of notes how to run fay across it. One trick helped me especially a lot when I tried to add new Fay file in the project.

For linux projects I do:

export GHC_PACKAGE_PATH=$(stack path --ghc-package-path)

For osx project: 

unset GHC_PACKAGE_PATH

It caused by:

So, this trick looks like workaround. Actually, it is workaround. I am thinking about how to mitigate it with proper combination of cabal/ghc/stack options.

Best Regards, Andrey