search

faylang / fay

A proper subset of Haskell that compiles to JavaScript
https://github.com/faylang/fay/wiki
BSD 3-Clause "New" or "Revised" License
1.29k stars 86 forks source link

Fix dependent compilation when it's triggered by stack #458

Closed swamp-agr closed 5 years ago

swamp-agr commented 5 years ago

Closes #457 as described in Solution Proposal section.

swamp-agr commented 5 years ago

Hi @bergmark,

Is there any chance to review and accept this PR? I am currently working on isomorphic web framework that uses fay-websockets under the hood. I want to ensure that it will be compatible with all build tools. I already tried cabal and there were no issues. However, stack produced some and I tried to fix them all.

Best Regards, @swamp-agr

swamp-agr commented 5 years ago

Any chances to merge it in 2018?

swamp-agr commented 5 years ago

Happy New Year!

@bergmark, May I ask you to consider me as co-maintainer for this package?

bergmark commented 5 years ago

Sorry I'm so slow, you are more than welcome as a co-maintainer! Thanks

bergmark commented 5 years ago

I've sent an invite to the github org, do you have a hackage account?

swamp-agr commented 5 years ago

Yes, it's swamp_agr (with underscore). BTW, I accepted your invitation. Thank you!

bergmark commented 5 years ago

I added you as a hackage maintainer for fay and fay-base as well

swamp-agr commented 5 years ago

@bergmark thank you! I will do my best!