Allow upload on upgraded hackage

faylang / fay

A proper subset of Haskell that compiles to JavaScript

https://github.com/faylang/fay/wiki

BSD 3-Clause "New" or "Revised" License

1.29k stars 86 forks source link

Allow upload on upgraded hackage #472

Closed swamp-agr closed 3 years ago

swamp-agr commented 3 years ago

Opening separate PR, since there is an error while uploading fay on hackage:

Uploading $HOME/projects/fay/dist-newstyle/sdist/fay-0.24.1.1.tar.gz...
Error uploading
$HOME/projects/fay/dist-newstyle/sdist/fay-0.24.1.1.tar.gz: http code 400
Error: Invalid package

'cabal-version' must be at least 1.10

Bumping to 1.10 did not helped.

swamp-agr commented 3 years ago

It seems that Travis CI is setting up cabal-install version 2.0. It's not aligned properly with spec-version 3.0. Trying adopt haskell-ci tool with current fay.cabal.

swamp-agr commented 3 years ago

Right now fay-tests cannot recognize installed ghc on CI server:

$ ${CABAL} v2-exec fay-tests -- --num-threads=4 -random 20
cabal: The program 'ghc' version >=7.0.1 is required but it could not be found.

The command "${CABAL} v2-exec fay-tests -- --num-threads=4 -random 20" exited with 1.

swamp-agr commented 3 years ago

As mentioned here (https://github.com/haskell/cabal/issues/6722), autogen-modules section could be skipped for executables.

swamp-agr commented 3 years ago

Now I am able to reproduce CI behaviour locally for 8.8 branch (similar to #470).

swamp-agr commented 3 years ago

Next steps:

resolve test errors one-by-one.

ghc-pkg: cannot find package fay-base

proposed solution: extend whatAGreatFramework with following logic:

✅ gather global, local package-db.
⚙️ if existed, add package-db from command-line arguments.
⚙️ ensure that parameter values are unique.

swamp-agr commented 3 years ago

After investigating, it was decided to postpone v2 handling as it is harder than I initially thought. For now, downgrading Travis CI from v2 to v1 resolves ghc-pkg error: fay-base is missing.