fazbear201 / winezeug

Automatically exported from code.google.com/p/winezeug
1 stars 0 forks source link

Civilization 4 Not Available (patch) #168

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. wisotool civ4

What is the expected output? What do you see instead?
Civilization 4 is installed successfully.

Unknown arg civ4

What version of the product are you using? On what operating system?
r1562

Linux

Please provide any additional information below.
This patch should work but you must use the No-CD patch.

I wasn't sure if it was okay to include a link to a No-CD patch however.
http://www.freeinfosociety.com/downloads/nocdcracks/civilization4-nocd-1_61-ENG.
zip

Original issue reported on code.google.com by mjbauer95 on 5 Sep 2010 at 12:19

GoogleCodeExporter commented 8 years ago
I don't see the patch. Civilization 4 isn't in wisotool. If you'd like to 
script it, please go ahead.

Please don't link to/include no-cd patches, however.

Original comment by austinenglish@gmail.com on 12 Sep 2010 at 5:43

GoogleCodeExporter commented 8 years ago
Sorry, it should be uploaded now.

Original comment by mjbauer95 on 12 Sep 2010 at 11:10

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the submission.   We loves new games patches, we do, yum.

A few notes about your patch:

1) This diff was probably not intended and may break the script (you probably
messed up the evil embedded CR):

-   echo "$@" | sed "s/\$/
+   echo "$@" | sed "s/\$/

2) No, it is not ok to mention cracks, not at all.  The warning at the
end is a good idea, but only surrounded with an 
  if workaround_wine_bug XXX
test, where XXX is the appropriate wine bug for this DRM scheme,
and only if it doesn't mention a crack or no-cd patch.

3) Since you're using titlematchmode 2, you can abbreviate really long lines, 
e.g.
        winwait, Sid Meier's Civilization 4 - InstallShield Wizard, I &accept the terms of the license agreement

can just be
        winwait, Civilization 4, accept the terms of the license

4) The ControlClicks are great, but you should test the patch to make
sure it works on Vista, too; often you either need to put a sleep before
those, or replace them with sent keystrokes, or both.

5) Workarounds like
     try sh "$WINETRICKS" -q msxml3
     try sh "$WINETRICKS" -q d3dx9
should be as narrow as possible (eg, do d3dx9_36 instead of d3dx9, if you can)
and each one should be surrounded with an if workaround_wine_bug test
(assuming it's not also needed on Windows).

6) Please remove commented lines like

+    #try sh "$WINETRICKS" -q vcrun2003

7) You can just send future patches to dank@kegel.com.  Please clean up
the above issues and resubmit.  I'm looking forward to committing this!

Original comment by daniel.r...@gmail.com on 13 Sep 2010 at 3:24

GoogleCodeExporter commented 8 years ago
Okay this should fix it. I still had that carriage return problem so I just 
removed those lines from the diff.

Original comment by mjbauer95 on 14 Sep 2010 at 1:32

Attachments:

GoogleCodeExporter commented 8 years ago
Here's a version with the rest of the issues I identified cleaned up.
I have yet to test it (don't have the game).

Hey, I see there's a 314MB demo, let's add a verb for that, too.  At least I 
can test that.

Original comment by daniel.r...@gmail.com on 15 Sep 2010 at 5:16

Attachments:

GoogleCodeExporter commented 8 years ago
Say, 
http://appdb.winehq.org/objectManager.php?sClass=version&iId=16878&iTestingId=45
146 says that patch 3.19 of
civ4 removes the DRM.  If the script could install that,
we could take off the nasty drm warning.

Original comment by daniel.r...@gmail.com on 16 Sep 2010 at 3:34

GoogleCodeExporter commented 8 years ago
I suppose the patch would work if you had the Beyond the Sword expansion pack, 
but at least I don't have BtS.

Original comment by mjbauer95 on 16 Sep 2010 at 4:00

GoogleCodeExporter commented 8 years ago
The demo works great, though in addition to what you had, I also had
to do winetricks d3dx9_26.

Original comment by daniel.r...@gmail.com on 16 Sep 2010 at 4:16

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r1598.

Original comment by daniel.r...@gmail.com on 19 Sep 2010 at 1:08