fbaiodias / react-video-recorder

https://react-video-recorder.vercel.app/
MIT License
188 stars 155 forks source link

Peer dependencies prevent module from properly installing alongside React 18 #181

Open sitarharel opened 1 year ago

sitarharel commented 1 year ago

Module was fixed to work with react 18 here: https://github.com/fbaiodias/react-video-recorder/issues/172

However, package.json was not updated to allow for react ^18.0.0 as a peer dependency and thus the following error appears on npm install:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: client@0.1.0
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.3 || ^17.0.0" from react-video-recorder@3.19.4
npm ERR! node_modules/react-video-recorder
npm ERR!   react-video-recorder@"^3.19.4" from the root project
npm ERR!
davidcedres commented 5 months ago

👀