search

fbaligand / kibana-enhanced-table

Kibana visualization like a Data Table, but with enhanced features like computed columns, filter bar, and “Split Cols” bucket
Apache License 2.0
309 stars 64 forks source link

Export link creates unsaved.csv #155

Closed rafreyes closed 3 years ago

rafreyes commented 3 years ago

Hi, I have encountered an issue when exporting the table (enhanced and document) as CSV through the export links. While the export is successful the filename generated is "unsaved.csv". Would it be possible to have the visualisation's name as the filename?

Thanks a lot for sharing this useful plugin

fbaligand commented 3 years ago

Hi,

Thanks to report this bug. I will try to fix it in next release.

fbaligand commented 3 years ago

Hi,

I tried to fix this issue, but actually there is no mean to, because vis title information is not provided by Kibana to plugin's controller.

So I just created a PR to Kibana core, so that it provides vis title information to a visualization plugin: https://github.com/elastic/kibana/pull/84456

Finally, this issue should happen only since Kibana 7.8

fbaligand commented 3 years ago

Hi,

My PR on kibana core (https://github.com/elastic/kibana/pull/84456) has been merged and will be available in Kibana 7.11.0. So this issue will be fixed in Kibana 7.11.0

rafreyes commented 3 years ago

Hello, thanks for the feedback. so, we'll wait for the 7.11 version have a nice day

fbaligand commented 3 years ago

Hi,

Waiting for Kibana 11, I just released Enhanced Table v1.11.0, and default name is now export.csv, in Kibana 7.8+. It is better than "unsaved.csv" :)

rafreyes commented 3 years ago

Hello,

yes, that's better. thank you

have a nice 2021 :)

fbaligand commented 3 years ago

Happy new year 2021 !

fbaligand commented 3 years ago

As expected, the bug has been solved in Kibana 7.11. So I close this issue.

fbaligand commented 2 years ago

Hi,

Finally, there was also a bug in Enhanced Table plugin code. I just fixed it in last release (v1.13.3), available here: https://github.com/fbaligand/kibana-enhanced-table/releases/tag/v1.13.3