Support for Kibana 8.7.0

sebprunierserli commented 1 year ago

Could you please release the plugin version for kibana 8.7.0.

Many thanks in advance !

fbaligand commented 1 year ago

Well, Kibana 8.7 brings breaking changes that requires changes in enhanced table plugin to be compatible. The good news is that I managed to do required changes in enhanced table so that it works with « kibana dev mode ». But the bad news is that it doesn’t work with « kibana prod mode ». I already tried several ways, but for now, I’m blocked. I will comment here when it will be available.

mvenukadasula commented 1 year ago

@fbaligand really appreciate for managing this plugin. Is there a tentative plan to release support for 8.7.x and 8.8.x?

fbaligand commented 1 year ago

Yes, there is a tentative plan. As explained in my previous comment, it works in kibana dev mode, but not in prod mode (the way you use it through kibana release). I already spent a lot of time to understand and fix the problem. But for now, it still does not work. I continue to look for the problem.

phihdn commented 1 year ago

Hi, can I try to build and deploy on the latest commit on the master branch?

fbaligand commented 1 year ago

Hi @phihdn,

Currently, I haven't commited the version for Kibana 8.7, as it does not work in prod mode. But here is the current version that you can install on Kibana 8.7.0 (and on Kibana 8.7.1 if you change "kibanaVersion" in kibana.json inside zip file) : enhancedTable-8.7.0.zip

And here is the actual source code: enhancedTable-source-8.7.0.zip

Feel free to test it! And if you find a way to fix this version in prod mode, I would be the happiest man in the world! ;)

phihdn commented 1 year ago

Hi @fbaligand,

Thank you for sharing the zip files. I tried on my Kibana 8.8.0. I changed the version as you guided. It said the installation was successful but it was not.

~$ bin/kibana-plugin install file:///etc/enhancedTable-8.8.0.zip
Attempting to transfer from file:///etc/enhancedTable-8.8.0.zip
Transferring 1036448 bytes....................
Transfer complete
Retrieving metadata from plugin archive
Extracting plugin archive
Extraction complete
Plugin installation complete

When I tried to list plugins, it's errored:

~$ bin/kibana-plugin list

/usr/share/kibana/src/cli_plugin/list/list.js:23
  plugins.forEach(([name]) => {
          ^
Error: Unable to read kibana.json file for plugin enhancedTable
    at /usr/share/kibana/src/cli_plugin/list/list.js:29:13
    at Array.forEach (<anonymous>)
    at list (/usr/share/kibana/src/cli_plugin/list/list.js:23:11)
    at Command.processCommand (/usr/share/kibana/src/cli_plugin/list/index.js:22:18)
    at Command.<anonymous> (/usr/share/kibana/src/cli/command.js:84:20)
    at Command.listener (/usr/share/kibana/node_modules/commander/index.js:370:29)
    at Command.emit (node:events:513:28)
    at Command.parseArgs (/usr/share/kibana/node_modules/commander/index.js:892:12)
    at Command.parse (/usr/share/kibana/node_modules/commander/index.js:642:21)
    at Object.<anonymous> (/usr/share/kibana/src/cli_plugin/cli.js:41:9)

Do you have same behaviors?

fbaligand commented 1 year ago

Well, first, the aim is to test with Kibana 8.7 (not 8.8 that will be next target). Then, I don't reproduce your issue, not on Kibana 8.7 nor on Kibana 8.8. Could you list files inside $KIBANA_HOME/plugins/enhancedTable ? You should verify that kibana.json is here. Then could you execute cat kibana.json and show here the result?

phihdn commented 1 year ago

Please ignore my previous comment. I did use kibana user to install the plugin instead root. That caused permission issue. After chmod enhancedTable dir and files, the plugin has been loaded and now I see the error on Kibana when I tried to create new enhancedtable. Regarding the version, since I have 8.8 ready so I just want to do a quick test while I am setting up the Kibana plugin development environment. I will setup another 8.7 instance to test. I will update here if I found something. Thank you.

Hrithik-Manchanda commented 1 year ago

Hi @fbaligand,

I would like to experiment this plugin in 8.7 version. It would help me if you push changes to git. I may try something here.

fbaligand commented 1 year ago

Hi @Hrithik-Manchanda,

To help you, I just published the current version for Kibana 8.7 in "8.7" branch. So you can checkout 8.7 branch and work on it. If you manage to find a change that makes it work in "prod" mode, I would enjoy that you create a PR!

pchakour commented 1 year ago

Hi @fbaligand,

I read in the given source code but I didn't find any mistake. So, I have supposed an issue in the kibana plugin helper and I found this thread: https://github.com/elastic/kibana/issues/154325

A fix seems to be merged in the branch 8.7, unfortunately I tried to build a version with the updated branch but got the same problem :-( I think you have to notify the Kibana team to resolve this issue.

fbaligand commented 1 year ago

Hi @pchakour,

First of all, I want to thank you for the time you spent to analyze the problem and look at a potential solution. I really appreciate!

Then, I looked at the issue, and found in the comments 3 potential ways to fix the issue:

update 8.7 branch to last commit (maybe I would be more lucky than you)
use 8.8 branch to build a 8.7 version
in Kibana webpack configuration, set "mode" to "production"

I will try these ways and give feedback here. If it doesn't work, as you mention, I will create an issue on Kibana repository.

fbaligand commented 12 months ago

Good news: using latest state of Kibana "8.7" branch, I finally manage to build a package that works on Kibana 8.7 standalone (production mode) !

So I should be able to publish soon the packages for Kibana 8.7.x !

Thanks again @pchakour for you help!

pchakour commented 12 months ago

Great news !!

I must have missed something when I tried to build on my side :thinking:

Anyway, I'm glad you made it :smile:

fbaligand commented 12 months ago

Well, I had to modify few things so that it compiles without error. I precise that with kibana v8.7.0 tag, I don’t needed that. I had to add a “common” directory (despite I don’t have server code), and I had to remove “IPrivate” export in angular/utils.

fbaligand commented 12 months ago

I'm glad to announce that Enhanced Table plugin for Kibana 8.7 is out!

You can get package here: https://github.com/fbaligand/kibana-enhanced-table/releases/tag/v1.13.4

fbaligand commented 12 months ago

New good news, plugin works also with Kibana 8.8! You can find the packages at the same place: https://github.com/fbaligand/kibana-enhanced-table/releases/tag/v1.13.4

mvenukadasula commented 11 months ago

Amazing!!! Thank you @fbaligand