search

fballiano / openmage-image-cleaner

Image cleaner for Magento 1 and OpenMage. Cleans orphans category, product and wysiwyg images.
19 stars 3 forks source link

New feature cleaning up /media/tmp directory #15

Closed ADDISON74 closed 3 years ago

ADDISON74 commented 3 years ago

When someone uploads an image first time it goes to /media/tmp/catalog/product directory. After pressing the [Save] button the file goes to /media/catalog/product directory then it is deleted from /tmp. Over the time there are still a lot of files in /media/tmp without any reason. What about including this directory in our clean up process? By filtering on a column we can get where is the file stored.

I did not check if for categories is the same pattern like for products (e.g. /media/tmp/catalog/category).

fballiano commented 3 years ago

well, I think we could simply add a button to delete the whole "media/tmp" folder, there's nothing that should be kept in there...

ADDISON74 commented 3 years ago

I agree. It is only a temporary area and what has been uploaded here is assumed to already exist locally or on the server. I am waiting for you with an implementation proposal when you have some time.

fballiano commented 3 years ago

Functionality was added in the 0.7.0 release ;-) let me know!

ADDISON74 commented 3 years ago

Excellent. I appreciate you fast reaction. I will test it and come back with a feedback. Have a lovely weekend.

ADDISON74 commented 3 years ago

After testing the new addition I did not find any issues, it works as expected. Between us this extension should be integrated in OpenMage. Deconf ImaClean is far behind as features and for years it was the only option.

fballiano commented 3 years ago

thanks! :-) that's nice to know