fballiano / openmage-image-cleaner

Image cleaner for Magento 1 and OpenMage. Cleans orphans category, product and wysiwyg images.
19 stars 3 forks source link

Small Improvements #3

Closed ADDISON74 closed 3 years ago

ADDISON74 commented 3 years ago

First Change Do we need the ID column? Let's say we note the ID's for some images we want to select and delete. But we can do the same thing using file name which is more intuitive for a human without noting too many information on a paper.

Second Change 200px for the image size is too big and a scrolling efforts is needed. I recommend 100px.

Third Changes

snip

fballiano commented 3 years ago
  1. not really but at the same time it's a way to recognize new/old images based on the ID. also, filename could by duplicated on different content_type_id so we'd have to use a double column key which I think it's not even possible in magento's grids (btw I'd still prefer to have the ID key like every other magento's model).
  2. mmm depends on the kind of images, for my customers it may be difficult to recognize a smaller image so I wouldn't go less than 200, at the same time we could make it configurable...
  3. header was added
  4. if I add the download action I think there should be a massDownload action, which may be challanging (big zip size, timeouts, how to delete the ZIP file after download) so I thought that it would be better not to have a download at all... anyways it's something easy to add
fballiano commented 3 years ago

I was trying to add the download action but, when there are multiple actions the column itself renders as combobox:

Schermata 2021-04-10 alle 23 27 36

which is extremely uncomfortable to use so that's a no.

then I tried add multiple action columns:

Schermata 2021-04-10 alle 23 29 52

but that it also ugly (and I'd remove the headers which don't make any sense in that case)

so.. mmmm I'm wondering what makes more sense

fballiano commented 3 years ago

I created a rendered and it's now nice and working:

Schermata 2021-04-11 alle 00 49 18

I decided to keep the "delete" link as last cause I think it's the most used and easiest to click

ADDISON74 commented 3 years ago

Excellent job. After using ImaClean for almost 8 years I found a new flavor thanks to you.

When pressing [Cancella] link you should ask "Are you sure?" like in Mass Delete actions. I posted an issue for this.

fballiano commented 3 years ago

I've created https://github.com/fballiano/magento1-image-cleaner/issues/10 to remind me about the thumb size ;-)

fballiano commented 3 years ago

thumbnail size is now configurable ;-)