fballiano / openmage-load-javascripts-on-intent

Load javascripts only when the user interacts with your OpenMage website
1 stars 1 forks source link

issues with schema ld+json #1

Open empiricompany opened 5 months ago

empiricompany commented 5 months ago

Just to report you that when the script type is not text/javascript, such as application/ld+json, we have two type attributes:

<script type="application/ld+json" type="text/plain">
    {
      "@context": "http://schema.org",
      "@type": "Organization",
      "url": "https://openmage-latest.loc/default/",
      "logo": "https://openmage-latest.loc/skin/frontend/rwd/default/images/logo.gif"
    }
</script>

The schema tested here still seems to be detected correctly: https://validator.schema.org/

fballiano commented 5 months ago

this module is just a test at the moment, it's really not working :-D

empiricompany commented 5 months ago

ah :-D ok sorry, checkout my testing module https://github.com/empiricompany/openmage_pagespeed if you want it works but i have to refactor it