fbartolic / caustics

Differentiable microlensing powered by JAX
https://fbartolic.github.io/caustics/
MIT License
13 stars 2 forks source link

Rethink tests which trigger the extended full computation #22

Open fbartolic opened 2 years ago

fbartolic commented 2 years ago

The tests from Bozza et. al. 2018 are quite wasteful in the sense that there are tons of false positives. Here's an example:

image

The red region is where the error is > $10^{-4}$ and the grey region is where the tests says that the full calculation is necessary. I feel like there has to be a way to improve the accuracy of these tests.

Perhaps we should treat this as a machine learning prediction problem and construct physically meaningful features such as the magnitude of the higher order terms in the multipole expansion and the value of Jacobian.

Related to #19.