fbattel1 / qbb2024-answers

0 stars 0 forks source link

QBIOLAB - Week 1 Assignment #7

Closed nicmoya closed 1 month ago

nicmoya commented 1 month ago

General Coding Tip:

  1. Avoid the use of hard-coded numbers. It’s best to define your variables under a reasonable name and use them within the rest of your code so that we can understand where they are coming from.
    cov = 30
    genome_size = 1e6
    xs = …
    norm_est = genome_size*dnorm(xs, cov, sqrt(cov))

Specific comments (Point deductions in parenthesis at the end of comments when applicable):

  1. The x-axis label in the histograms should just be ‘Coverage’, considering you are counting observations at a wide range of coverage values. 3x/10x/30x could have been incorporated in a figure title, as it describes the depth of your sampling for the simulation. (-0.25 per plot)
  2. The histogram plots could benefit from a more informative legend title (or lack of!), and some minor aesthetic changes through theme() (such as the addition of some axis lines)

Code: 5/5 Answers: 3/3 Plots: 1.25/2

Total: 9.25

nicmoya commented 1 month ago

Issues are resolved.

Regrade: Code: 5/5 Answers: 3/3 Plots: 2/2 Total: 10