fbdevelopercircles / open-source-edu-bot

Open Source Education bot, built by the Developer Circles community.
MIT License
59 stars 79 forks source link

Arabic translation #116

Closed Fady-Ibra closed 4 years ago

Fady-Ibra commented 4 years ago

Is your pull request related to a problem? Please describe

The PR related to the issue Internalization: Add your local language #57

Describe the solution you'd like

Add the Arabic translation to src/locales/ar/LC_MESSAGES/messages.po and src/services/profile.py.

Test plan

There are no new tests added.

aboullaite commented 4 years ago

Thank you @fady-a-m-ibrahim for the effort you put to add arabic support! However, the translation is a word to word translation, instead of semantic translation, which is very important in our case.

Fady-Ibra commented 4 years ago

Thank you @aboullaite for your comment. Could you please give me an example of a word to word translation and the semantic translation that should be.

Fady-Ibra commented 4 years ago

Hello @aboullaite, Hoping you are doing fine. There is an update, I have resolved the conflict in src/services/profile.py Great Thank you,

aboullaite commented 4 years ago

Sounds good! Also, all files should have this license header

# Copyright (c) Facebook, Inc. and its affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
Fady-Ibra commented 4 years ago

Thank you @aboullaite for your support. I have added the license header.

Fady-Ibra commented 4 years ago

Thank you @elinguiuriel I have removed the second copyright.

elinguiuriel commented 4 years ago

Thank you @elinguiuriel I have removed the second copyright.

@fady-a-m-ibrahim LGTM, @aboullaite will have a last look as an Arabic speaker and merge your PR, very nice work 🥇

aboullaite commented 4 years ago

Thank you for bearing with us @fady-a-m-ibrahim throughout this PR! Great work

Fady-Ibra commented 4 years ago

I do appreciate your help @elinguiuriel during this PL. Great Thank you.

Fady-Ibra commented 4 years ago

Thank you @aboullaite for all your support and nice comments. I do appreciate it.

elinguiuriel commented 4 years ago

@fady-a-m-ibrahim make sure to set Arabic as your Facebook language and test the chatbot here: https://m.me/OpenSourceChatbot

After many challenges #122 and #123, I was able to make Arabic works

image

image

aboullaite commented 4 years ago

Thanks a lot @elinguiuriel 🙏👌