Closed Fady-Ibra closed 4 years ago
Thank you @fady-a-m-ibrahim for the effort you put to add arabic support! However, the translation is a word to word translation, instead of semantic translation, which is very important in our case.
Thank you @aboullaite for your comment. Could you please give me an example of a word to word translation and the semantic translation that should be.
Hello @aboullaite, Hoping you are doing fine. There is an update, I have resolved the conflict in src/services/profile.py Great Thank you,
Sounds good! Also, all files should have this license header
# Copyright (c) Facebook, Inc. and its affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
Thank you @aboullaite for your support. I have added the license header.
Thank you @elinguiuriel I have removed the second copyright.
Thank you @elinguiuriel I have removed the second copyright.
@fady-a-m-ibrahim LGTM, @aboullaite will have a last look as an Arabic speaker and merge your PR, very nice work 🥇
Thank you for bearing with us @fady-a-m-ibrahim throughout this PR! Great work
I do appreciate your help @elinguiuriel during this PL. Great Thank you.
Thank you @aboullaite for all your support and nice comments. I do appreciate it.
@fady-a-m-ibrahim make sure to set Arabic as your Facebook language and test the chatbot here: https://m.me/OpenSourceChatbot
After many challenges #122 and #123, I was able to make Arabic works
Thanks a lot @elinguiuriel 🙏👌
Is your pull request related to a problem? Please describe
The PR related to the issue Internalization: Add your local language #57
Describe the solution you'd like
Add the Arabic translation to src/locales/ar/LC_MESSAGES/messages.po and src/services/profile.py.
Test plan
There are no new tests added.