fbdevelopercircles / open-source-edu-bot

Open Source Education bot, built by the Developer Circles community.
MIT License
59 stars 79 forks source link

Support for spanish language #137

Closed Cegard closed 3 years ago

Cegard commented 3 years ago

Is your pull request related to a problem? Please describe

A clear and concise description of what the problem is. Ex. I'm always frustrated when ...

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Test plan

A good test plan should give instructions that someone else can easily follow. Also add a link to your own Messenger experience for your reviewer to test the changes.

Checklist

aboullaite commented 3 years ago

Thanks for your contribution @Cegard. Can you please fix conflicts!

Cegard commented 3 years ago

Conflicts were fixed again.

Cegard commented 3 years ago

Conflicts were fixed again.

elinguiuriel commented 3 years ago

@Cegard thank you so much, I love when someone adds a new language to the bot

elinguiuriel commented 3 years ago

@Cegard make sure your facebook language is spanish and test the chabot here https://m.me/OpenSourceChatbot

image

Pay attention to untranslated phrases that you can correct in a new PR :-) !

Cegard commented 3 years ago

Hi @elinguiuriel I'm glad to contribute to this project. I took a look at the untranslated text and I decided that the way to go with this was adding the msgid in the messages.po, but I'm not sure if this is the proper fix or just a workaround, What do you think?