Adding contributors section

fbdevelopercircles / open-source-edu-bot

Open Source Education bot, built by the Developer Circles community.

MIT License

59 stars 79 forks source link

Adding contributors section #26

Closed vinitshahdeo closed 4 years ago

vinitshahdeo commented 4 years ago

Is your pull request related to a problem? Please describe

The Contributors section in README.md is missing.

Describe the solution you'd like

Added a list of contributors with a link to the contributions graph
Added a PRs Welcome badge which links to CONTRIBUTING.md

Additional context

I suggest you to add Hall of Fame in README.md under contributors section.

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.
[ ] I have added the label enhancement to my pull request.

aboullaite commented 4 years ago

Such a great feature @vinitshahdeo. Thank you! However, I was thinking about it and it inspired me to push it a little further by automating this process 💯 Something like all-contributors-bot could really help us here.

WDYT ?! Is this something you can work on ?

vinitshahdeo commented 4 years ago

@aboullaite Hey, thanks for the quick response. Yes, I can work upon adding the all-contributors-bot. What do you think about Hall Of Fame? Which one shall we go for?

PS: To add these bots, I need to be a member of the org, can you please invite me?

aboullaite commented 4 years ago

Both are valid solution IMO! I have a slightly preference for all-contributors-bot. @caabernathy @elinguiuriel @Awinja-j WDYT ?

caabernathy commented 4 years ago

I like both as well. The leaderboard like nature of Hall of Fame makes it more interesting to me. Unfortunately it doesn't give love to everyone so all contributors may be best in the short term.

vinitshahdeo commented 4 years ago

@aboullaite @caabernathy @tvalentius Finally, are we going with Hall Of Fame?

See Hall Of Fame in action here.

elinguiuriel commented 4 years ago

@vinitshahdeo ok for me !

vinitshahdeo commented 4 years ago

@elinguiuriel Org access is required to generate Hall of Fame. Can you please invite me to the org?

aboullaite commented 4 years ago

@vinitshahdeo adding the Bot to the org is a WIP! We already submitted a request to devc team :) keep you posted

aboullaite commented 4 years ago

@vinitshahdeo Adding the bots won't be possible in the near future. What we could do instead is something I described in #37! Wdyt @caabernathy @elinguiuriel @Awinja-j

caabernathy commented 4 years ago

I would agree with you on your recommendation @aboullaite.

aboullaite commented 4 years ago

I believe we can close this PR as we have now a clear vision described in #37