search

fbergama / wass

WASS (Waves Acquisition Stereo System) is an optimized stereo processing pipeline for sea waves 3D reconstruction.
GNU General Public License v3.0
40 stars 13 forks source link

Wass.js: Depreciation warnings #5

Open saltynexus opened 6 years ago

saltynexus commented 6 years ago

Using node v8.4.0 and npm 5.3.0.

Following the Getting Started tutorial, here is the command window output

DirScan
Scan completed.
Cam0 files:
[ '000000_0000000000000_01.tif',
  '000001_0000000083342_01.tif',
  '000002_0000000166652_01.tif',
  '000003_0000000249994_01.tif',
  '000004_0000000333336_01.tif',
  '000005_0000000416678_01.tif' ]
Cam1 files:
[ '000000_0000000000000_02.tif',
  '000001_0000000083341_02.tif',
  '000002_0000000166650_02.tif',
  '000003_0000000249991_02.tif',
  '000004_0000000333333_02.tif',
  '000005_0000000416674_02.tif' ]
Dir scan completed
[ ] JOB  1 (prepare)
[ ] JOB  2 (prepare)
[ ] JOB  3 (prepare)
[ ] JOB  4 (prepare)
[ ] JOB  5 (prepare)
[ ] JOB  6 (prepare)
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
[X] JOB  6
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
[X] JOB  4
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
[X] JOB  2
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
[X] JOB  5
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
(node:4932) [DEP0013] DeprecationWarning: Calling an asynchronous function witho
ut callback is deprecated.
[X] JOB  3
[X] JOB  1
Queue empty!
Using the following wdir_subset: 2,3,5,1,4,0
[ ] JOB  7 (match)
[ ] JOB  8 (match)
[ ] JOB  9 (match)
[ ] JOB  10 (match)
[ ] JOB  11 (match)
[ ] JOB  12 (match)
[X] JOB  8
[X] JOB  12
[X] JOB  11
[X] JOB  9
[X] JOB  10
[X] JOB  7
Queue empty!
[ ] JOB  13 (matchmerge)
[X] JOB  13
Queue empty!
[ ] JOB  14 (dense)
[ ] JOB  15 (dense)
[ ] JOB  16 (dense)
[ ] JOB  17 (dense)
[ ] JOB  18 (dense)
[ ] JOB  19 (dense)
[X] JOB  15
[X] JOB  19
[X] JOB  18
[X] JOB  17
[X] JOB  16
[X] JOB  14
Queue empty!

The "depreciation warnings" arise when clicking "prepare" in the web interface. All other functions appear to work as intended.

One other thing, not really an issue, but in your documentation under step 2 you say "If you look inside the /test/WASS_TEST/output_W07/ you should see that a new directory has been created for each input stereo pair. ". This is inconsistent with the way the "worksession.json" file is configured in the windows binary package. It has "workdir":"../test/output_W07/", where it should be "workdir":"../test/WASS_TEST/output_W07/" for consistency.

fbergama commented 6 years ago

One other thing, not really an issue, but in your documentation under step 2 you say "If you look inside the /test/WASS_TEST/output_W07/ you should see that a new directory has been created for each input stereo pair. ". This is inconsistent with the way the "worksession.json" file is configured in the windows binary package. It has "workdir":"../test/output_W07/", where it should be "workdir":"../test/WASS_TEST/output_W07/" for consistency.

You are right! I need to change the documentation accordingly