search

fbergmann / libSEDML

SED-ML library based on libSBML
BSD 2-Clause "Simplified" License
9 stars 12 forks source link

Fix Issue 96: rename style to type #117

Closed luciansmith closed 3 years ago

luciansmith commented 3 years ago

This will break old code, but better to do it sooner rather than later.

I don't think preserving backwards compatibility is a reasonable goal--not many SED-ML files have been created so far, and most of them were created this last week--we can absolutely just make the changes.

fbergmann commented 3 years ago

@luciansmith looks fine to me, i was wondering if libsedml should continue to at least read the 'style' versions of the files, so that things would continue to work for those that have been using the l1v4 draft over the past year?

luciansmith commented 3 years ago

As I commented, I'm personally inclined to not provide backwards compatibility. Notwithstanding that it's been out a year, I don't think many people who are using it have been using the 'style' functionality until HARMONY. I could be wrong, and it'd be pretty simple to add reading of 'style' into the readAttributes function, if we wanted. Can we not for now, and add it if we get requests?

matthiaskoenig commented 3 years ago

I am fine with the change. I can just update my examples and code. No need for backwards compatibility with a draft version.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication