search

fbergmann / libSEDML

SED-ML library based on libSBML
BSD 2-Clause "Simplified" License
9 stars 12 forks source link

Setting empty component names clears component ids #152

Closed jonrkarr closed 2 years ago

jonrkarr commented 3 years ago

Example:

import libsedml

# create data set
data_set = libsedml.SedDataSet()

# set id
assert data_set.setId('obj') == 0

# check id set
assert data_set.getId() == 'obj'

# set empty name
assert data_set.setName('') == 0

# id is no longer set!
assert data_set.getId() == 'obj'

Environment:

luciansmith commented 3 years ago

Whoops! Sorry about that--simple fix, now with pull request.

jonrkarr commented 3 years ago

Thanks!

fbergmann commented 3 years ago

made a new release with the fix, will upload python binaries over the day as they get ready.