SedSubTask should not have methods for getting/setting ids

fbergmann / libSEDML

SED-ML library based on libSBML

BSD 2-Clause "Simplified" License

9 stars 12 forks source link

SedSubTask should not have methods for getting/setting ids #95

Closed jonrkarr closed 3 years ago

jonrkarr commented 3 years ago

sedml:SubTask (which directly inherits from SedBase) does not have an id attribute. However, libsedml.SedSubTask has getId, setId, and isSetId methods.

The methods should be removed.

They are not consistent with the SED-ML schema
libSED-ML neither reads nor writes the id attribute to/from files

fbergmann commented 3 years ago

for whatever reason, lucian needd id on everything ... and so in l1v4 they will be added everywhere. I'll look into why they are not saved though.

matthiaskoenig commented 3 years ago

I think this issue can be closed with the the recent id/name updates.