search

fbergo / zseal

FICS timeseal v2 client implementation
19 stars 5 forks source link

xboard 4.8.0 hangs at logout #1

Open shining-fnml opened 7 years ago

shining-fnml commented 7 years ago

Hi, thanks for giving us back the timeseal! I used it with xboard and I noticed a wrong behavior at logout time: in the case zseal reads 0 bytes from the socket (connection closed) the program exits and xboard knows nothing about what's happening. This leaves xboard hanging and zseal becomes a zombie. At least this happened to me with xboard 4.8.0 running on debian jessie x86_64 GNU/Linux 4.4.31-11 I worked around this writing a small patch. I don't know how good is my patch with interfaces other than xboard. If you are interested I can request a pull. Thank you

-Shining

fbergo commented 7 years ago

Hi, I've noticed this behavior occasionally, but it is hard to reproduce. I'll be travelling with restricted computer access for the next two weeks. For now, please keep testing your changes. If it actually fixes the problem for good, submit the pull request. I'll only be able to take a look and test it after April 17th anyway.

JoshuaPettus commented 7 years ago

I'm pretty sure there was an issue with XBoard 4.8 with FICS. It was several years ago. It has long been fixed with xboard 4.9.1 being the current version. Not that distros seem to keep it up to date.

fbergo commented 6 years ago

Is this still an issue with xboard 4.9.0 for anyone ? I can't reproduce it on my machines, and I'm considering closing this issue.

IAHM-COL commented 3 years ago

I implanted this on ChessX, and I find no issue,

Regards,