json_encode invalid response

fbett / le-acme2-php

LetsEncrypt client library for ACME v2 written in PHP.

MIT License

30 stars 15 forks source link

json_encode invalid response #12

Closed rlankhorst closed 3 years ago

rlankhorst commented 3 years ago

Hi @fbett,

I encountered some issues when I wanted to parse and output the response errors when an error is thrown. If I json_encode the response, I can easily read is as an object/array.

Please take a look at the proposed change and let me know what you think.

fbett commented 3 years ago

Hi @rlankhorst,

thx for contribution! Your right, here is something wrong.

It was a temporary solution to var_export the RawResponse, to find a way to get an error indicator: This exception should hopefully not thrown very often.

Two commits should satisfy your requirement to access the raw response (add4fa7c3081dd6406cdf04b0e567ed9c934c74b) and my requirement to output a good message (9b28e2f6af3143018c1932c6a32dbe40f2b2ade2)