search

fbl773 / point-b_ank

Forked from PCubed by the marvelous 371 team 4
Apache License 2.0
0 stars 0 forks source link

Period creation has wrong year validation rules #5

Open fbl773 opened 5 months ago

fbl773 commented 5 months ago

~bug

Observed on Develop running platform ALL for feature Add Period: Cultures are measured in years "Before Present" (BP). The "Start Year" will always be greater than the "End year". Validation checks prohibit this configuration however

When creating a period, the start year should always be greater than the end year

Recreation Steps

  1. Login
  2. Go to "Periods Managment"
  3. Create a new period
  4. Enter a start date that is greater than the end date
  5. OBSERVE --> Error text "Pleas enter a valid start and end year"

Screen Shot 2024-04-16 at 20 16 59

fbl773 commented 3 months ago

We should also change the form field to be "Year BP" or something. @Flake-bender, what would you call this field?

Flake-bender commented 3 months ago

We should also change the form field to be "Year BP" or something. @Flake-bender, what would you call this field?

Either "Age" or "Date range" Yes, "Years BP" seems good

fbl773 commented 2 months ago

Being Addressed in #43