search

fbnzk / leveldb

Automatically exported from code.google.com/p/leveldb
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

INSTALL_PATH was dropped from Makefile in 075a35a6d390167b77b687e067dd0ba593e7f624 #112

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Make leveldb on OS X
2. Note lack of absolute install path in `-install_name`
3. Attempt to build against leveldb dylib on OS X and fail

What is the expected output? What do you see instead?

g++  -dynamiclib -install_name libleveldb.dylib.1 

instead of

g++  -dynamiclib -install_name /path/to/current/directory/libleveldb.dylib.1 

What version of the product are you using? On what operating system?

Anything after SHA 075a35a6d390167b77b687e067dd0ba593e7f624

Please provide any additional information below.

It looks like when

$(SHARED3):
    $(CXX) $(LDFLAGS) $(PLATFORM_SHARED_LDFLAGS)$(SHARED2) $(CXXFLAGS) $(PLATFORM_SHARED_CFLAGS) $(SOURCES) -o $(SHARED3)

was made, the $(INSTALL_PATH) param was dropped completely.

The attached patch corrects this.

Original issue reported on code.google.com by j...@somethingsimilar.com on 21 Aug 2012 at 5:44

Attachments:

GoogleCodeExporter commented 9 years ago 
Unclear how this go duplicated. Feel free to close this one in favor of 111.

Original comment by j...@somethingsimilar.com on 21 Aug 2012 at 5:53

GoogleCodeExporter commented 9 years ago

Original comment by dgrogan@chromium.org on 22 Aug 2012 at 6:08