search

fboehm / qtl2pleio

Testing pleiotropy vs. separate QTL in multiparental populations
Other
5 stars 1 forks source link

Need unit tests for proper handling of checking on identical ordering of subject names #6

Closed fboehm closed 6 years ago

fboehm commented 6 years ago

In scan_pvl, I have stopifnot() to check that subject names in the various inputs are identical. I need to write unit tests to ensure that these checks work as intended.

fboehm commented 6 years ago

Check, also, for the possibility that one passes a single column covariate, but that every subject has the same value in it. Does my code handle this properly?

fboehm commented 6 years ago

Done. Early in code for scan_pvl, we check these two conditions. Note that I changed the code from what was present when the initial issue was opened. As of today, we check subject IDs for all inputs and use only those subjects that are present in all objects.