search

fboender / multi-git-status

Show uncommitted, untracked and unpushed changes for multiple Git repos
MIT License
470 stars 73 forks source link

Repositories under 2 levels deep of a regular folder are not checked #34

Closed ceremcem closed 4 years ago

ceremcem commented 4 years ago

Reproduction

$ mkdir -p a/b/c
$ cd a/; git init foo 
Initialized empty Git repository in /home/ceremcem/.sbin/multi-git-status/a/foo/.git/
$ cd b/; git init bar
Initialized empty Git repository in /home/ceremcem/.sbin/multi-git-status/a/b/bar/.git/
$ cd c; git init baz
Initialized empty Git repository in /home/ceremcem/.sbin/multi-git-status/a/b/c/baz/.git/
$ cd ../../..
$ ./mgitstatus --depth=0 a/
a/b/bar: Uncommitted changes 
a/foo: Uncommitted changes

Expected

Output should also include the following:

a/b/c/baz: Uncommitted changes
ceremcem commented 4 years ago

Looks like a documentation error. The following works correctly: 

./mgitstatus --depth 0 a/

However, as --parameter=value is more sensible, this issue should be handled as a coding error.

fboender commented 4 years ago

Hey ceremcem!

Thanks for the feedback. I'm going to leave the parameter as it is now. Seems like it's just a matter of personal preference, and I think it's fine the way it is.