search

fboender / multi-git-status

Show uncommitted, untracked and unpushed changes for multiple Git repos
MIT License
470 stars 73 forks source link

Lots of improvements #43

Open ceremcem opened 3 years ago

ceremcem commented 3 years ago
solarchemist commented 3 years ago

Support for git submodules would be awesome! Great work, hope it can be incorporated into mgitstatus.

braydentraas commented 3 years ago

Git submodules is a must-have! Thanks for adding this support.

However, I have 2 issues:

  1. It doesn't work on ZSH: git config --file=.gitmodules --get-regexp ^^submodule.*\.path$ | cut -d " " -f 2 (can be fixed by wrapping the regex in quotes: "^^submodule.*\.path$")
  2. It doesn't work on macOS: find -L "$DIR" $FIND_OPTS -depth -name ".git" -printf "%h\0" (no -printf flag on BSD's find)

It worked great on Bash/Linux; I'm hoping this can be resolved and merged soon.

Cheers!

ceremcem commented 3 years ago

@braydentraas Does gfind solve the issue on Mac: https://superuser.com/a/293200/187576?

braydentraas commented 3 years ago

@ceremcem Yes it does, but now readarray isn't available on mac/BSD either (or zsh even on linux)

ceremcem commented 3 years ago

As I don't have Mac on hand, I'm not sure how to proceed here. Are you able to implement the necessary changes and test on Mac? (I even didn't know this repo has been supporting Mac)

btraas commented 3 years ago

@ceremcem I've made a few changes and submitted a PR to your repo. Works for me now on MacOS/ZSH and Linux/Bash

Thanks again!

andrejpan commented 7 months ago

Any idea why this is not yet merged?

ceremcem commented 7 months ago

Don't know.

andrejpan commented 7 months ago

@ceremcem thank you for your updates!