fbonetti / elm-rails

View helpers for incorporating Elm modules into Rails views
MIT License
75 stars 20 forks source link

Add debug flag based on ENV['ELM_RAILS_DEBUG']. #19

Closed nvaldes closed 7 years ago

nvaldes commented 7 years ago

Debug is disabled if ENV['ELM_RAILS_DEBUG'] is unset (aka, nil), or set to either 'false' or '0'. Any other value will enable debug.

This should pass once PR 6 from ruby-elm-compiler gets merged.

nvaldes commented 7 years ago

Added tests, and made changes to get those to work. All tests pass on my end when I use my elm-compiler fork as the source in the 3 gemfiles.

lsimoneau commented 7 years ago

@nvaldes I bumped the version on elm-compiler after merging your commits there, so this needs an update to point to the new version, and also there are a few conflicts so needs rebasing on master.

lsimoneau commented 7 years ago

Updated and merged in https://github.com/fbonetti/elm-rails/pull/22