search

fbonetti / elm-rails

View helpers for incorporating Elm modules into Rails views
MIT License
75 stars 20 forks source link

Bump elm-compiler and expose elm_make_path configuration option. #20

Closed botandrose closed 7 years ago

botandrose commented 7 years ago

Hello! I have several Rails projects on my developer machine, many of them using elm-rails. Some apps are still on Elm 0.16, while some are still on Elm 0.17, and only a few are are on Elm 0.18. Therefore, its very helpful to specify in the configuration of each project which version of Elm to use. This PR does exactly that, by bumping elm-compiler to 0.2.1 and exposing a new elm_make_path configuration option. This should all be backwards compatible with the current release.

What do you think?

lsimoneau commented 7 years ago

Looks good to me, I'll merge it once the build goes green. I'm waiting on getting some stuff merged into the compiler repo so we can merge https://github.com/fbonetti/elm-rails/pull/19 here, once we have both of these changes in I'll bump the version and do a new release.

botandrose commented 7 years ago

@lsimoneau And we're green! Thanks for your quick response on this! :green_heart: