Closed yilmazbahadir closed 2 years ago
Please also run
npm run style:fix
to update the index.ts and docsI have done the following testing:
Multisig M, cosigners A,B,C , ServiceOperatorAccount S. It looks really nice:
- Convert to multisig M using M private key. It creates a bonded where All A,B,C need to cosign.
- Modify mutlisg M using A cosigner private key. It creates a bonded where some of B,C to cosign
- Convert to multisig M using S private key. It creates a bonded where all M, A, B, C need to cosign (wallet warning shown as expected)
- Modify multisig M using S private key. It creates a bonded where some A, B, C need to cosign (wallet warning shown as expected)
Could the command ask (optionally) for cosigners private keys. Use case, I'm a regular user that wants to convert my main account to multisig for security reasons. I could provide my cosigners private keys on the spot without bonded, using full aggregate complete. This could be an improvement though, the service providers should never know any cosigner private key.
Great! Will run the style:fix
script. Let's implement this improvement with a different PR, created https://github.com/symbol/symbol-bootstrap/issues/308.
Currently writing some unit tests and also adding some parameter sanity checks, will be updating the PR shortly.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells
No Coverage information
0.0% Duplication
symbol-bootstrap modifyMultisig
command is added. It's useful to convert main account into a multisig account or to modify the multisig account structure. Takes the following parameters, the user will be prompted for the unset parameters.