search

fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 28 forks source link

fix: removed hardcoded node list from preset. Using statistic services #309

Closed fboucquez closed 2 years ago

yilmazbahadir commented 2 years ago

Great work mate! Just a small comment and the following.

Can you rebase your branch on top of dev? Looks like there is a conflict, the following code will probably need a refactor and might move into TransactionUtils (also used by ModifyMultisigService) . https://github.com/symbol/symbol-bootstrap/blob/c846846245e02d8886fac5985374da0a15b05a83/src/service/AnnounceService.ts#L121

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication