search

fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 27 forks source link

fix: Removed npm module root folder location param. #321

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

It can be resolved without client code intervention, it works better when bootstrap is installed as a library for an app.

Another pr for better custom app integration

To be merged after 1.1.1 release

Jaguar0625 commented 2 years ago

are you sure that no one using bootstrap as a library would want to use a custom path?

fboucquez commented 2 years ago

are you sure that no one using bootstrap as a library would want to use a custom path?

The only reason I can think: A dev using bootstrap as a lib and wants to customize anything on the config or presets folder (that cannot be done via custom presets). If the dev does that, it would need to copy and paste both folders in a different location.

Should we keep dev provided root folder? If a dev needs to do something like that, it might be better to do a feature request to improve bootstrap customization. I am pretty sure I am the only one using bootstrap as lib in my network tools.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication