fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 27 forks source link

Statistic service wrong network node #327

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

This is more a statistic service bug, but I wondering if bootstrap should filter out the wrong network nodes.

$ symbol-bootstrap link --useKnownRestGateways
                         _             _         _                    _         _                      
  ___  _   _  _ __ ___  | |__    ___  | |       | |__    ___    ___  | |_  ___ | |_  _ __  __ _  _ __  
 / __|| | | || '_ ` _ \ | '_ \  / _ \ | | _____ | '_ \  / _ \  / _ \ | __|/ __|| __|| '__|/ _` || '_ \ 
 \__ \| |_| || | | | | || |_) || (_) || ||_____|| |_) || (_) || (_) || |_ \__ \| |_ | |  | (_| || |_) |
 |___/ \__, ||_| |_| |_||_.__/  \___/ |_|       |_.__/  \___/  \___/  \__||___/ \__||_|   \__,_|| .__/ 
       |___/                                                                                    |_|    
? Enter the password used to encrypt and decrypt custom presets, addresses.yml, and preset.yml files. When providing a passwo
rd, private keys will be encrypted. Keep this password in a secure place! 
Password has not been provided (empty text)! It's recommended to use one for security! (WARN)
Linking nodes
Getting nodes information from https://testnet.symbol.services/nodes?filter=suggested&limit=10
Looking for the best node out of:  
 - https://sym-test-01.opening-line.jp:3001
 - https://ngl-dual-601.testnet.symboldev.network:3001
 - http://testnet.symbol.nagoya:3000
 - https://sym-test-04.opening-line.jp:3001
 - https://ngl-dual-502.testnet.symboldev.network:3001
 - https://00.symsym.info:3001
 - https://7.dusan.gq:3001
 - https://yamatanoorochi.sfn.tools:3001
 - http://194.135.81.99:3000
 - http://52.27.173.72:3000
Connecting to node https://00.symsym.info:3001
Node's minFeeMultiplier is 100
    Error: You are connecting to the wrong network. Expected generation hash is 
    3B5E1FA6445653C971A50687E75E6D09FB30481055E3990C84B25E9222DC1155 but got 
    57F7DA205008026C776CB6AED843393F04CD458E0AA2D9F1D5F31A402072B2D6

Currently, the link is rejecting the incorrect node. Other commands may use the nodes as-is.

It could be harder to filter out peer-only nodes and adding the checks to bootstrap will just make the process slower.

This will probably be fixed once the statistic service bug is fixed

fboucquez commented 2 years ago

Fixed on statistic service