search

fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 27 forks source link

fix: audit fix update #330

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

fix: updated sdk to latest 1.0.3

Audit fix, Updated oclif to latest since audit patch was failing. Generated docs is slightly different Replace '@oclif/test' with standard 'chai' imports

-mocha upgrade to 9.1.3 -eslint upgrade to 7.32.0 -create-ts-index to 1.13.7

No npm audit vulnerabilities

fboucquez commented 2 years ago

imo name of PR is misleading, since this is only bumping symbol-sdk version

You can see the output of npm audit fix in the package.lock file. Some libraries were patch updated. oclif did break the doc generation so I need to revisit (probably a circular dependency).

I'll update this branch to just SDK upgrade

fboucquez commented 2 years ago

Hi @Jaguar0625 , could you have a look? I have done the npm audit upgrade + other third party mayor updates to not have npm audit vulnerabilities

Jaguar0625 commented 2 years ago

what does this have to do with an audit fix?

fboucquez commented 2 years ago

Which one? let me split further

https://github.com/symbol/symbol-bootstrap/pull/347 https://github.com/symbol/symbol-bootstrap/pull/348 https://github.com/symbol/symbol-bootstrap/pull/349

Jaguar0625 commented 2 years ago

is there anything left in this PR not in the other PRs?

fboucquez commented 2 years ago

is there anything left in this PR not in the other PRs?

just plain 'npm audit fix'

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication