search

fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 28 forks source link

Nemesis configuration improvements #337

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

~1. Fixed config/start --preset and --assembly options (it was the other way around)~ Already merged in another pr

  1. Removed unnecessary currency names from custom preset. It can be provided and resolved from the nemesis.mosaics field
  2. Moved "opt-in" addresses/balances from nemesis to nemesis.mosiac. User (or symbol-network) can provide balances for multiple mosaics, although most of the time there is only one nemesis mosaic (like xym).
  3. Allow a node to be excluded from nemesis (no balance or linked transactions).
  4. Allow users to provide node nemesis balance. If the balance is calculated, it will be less than maxHarvesterBalance
  5. Better nemesis supply distribution and exception handling. Added unit tests.

If this is too much I can split further. Note I would be creating a new PR where the genesis related configuration is moved to their own class/service

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication