fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 28 forks source link

fix: voting key file provider #338

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

This improvement allows devs to use another mechanism for voting key file creating. I would be using this in 2 ways:

1) I have a suite of tests to be pushed that does deep-dir comparison of different setups. The unit test needs a way to generate static files so we can do the assertions on all the files.

The incoming test and unit test file provider: https://github.com/symbol/symbol-bootstrap/blob/networkPresetFile/test/service/BootstrapService.test.ts https://github.com/symbol/symbol-bootstrap/blob/networkPresetFile/test/service/BootstrapService.test.ts#L55

I need other PRs before pushing those unit tests.

2) Symbol services pre-create the voting files when generating the nemesis block on new networks, so they can then be used when creating each node. Those files are stored in the symbol-network's key-store.yml.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication