search

fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 27 forks source link

fix: removed unused files after nemesis block is generated. #339

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

This PR removes the nemesis block temp files after generation. We can then have deterministic nemesis seed folder generation and compare folders in unit tests (Future PR).

Jaguar0625 commented 2 years ago

This PR removes the nemesis block temp files after generation.

Removes from where? Local machine or a deployed server?

fboucquez commented 2 years ago

Hi @Jaguar0625 , the issue description wasn't the best.

When the user runs -p bootstrap, the nemgen creates all these files:

image

This PR is to clean up the files the catapult client doesn't require saving space and helping me with the unit test suite that it's coming

Jaguar0625 commented 2 years ago

why are you not running nemgen with useTemporaryCacheDatabase option?

fboucquez commented 2 years ago

why are you not running nemgen with useTemporaryCacheDatabase option?

Thanks! I didn't know the option.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication