fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 27 forks source link

feat: joeynet reset #341

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

This joynet configuration is the one I generated using the symbol-network tool. This pr "officialize" it by distributing it with the bundled testnet reset.

The network.yml configuration would be slightly different once https://github.com/symbol/symbol-bootstrap/pull/331 is merged.

The network, seed nodes configuration, and accounts can be found in the new private repo https://github.com/symbol/symbol-testnet

This PR includes the initial node seeds. Statistic service would be "empty" until we have launched the seed nodes. We would need to reset and reconfigure the statistic service soon after joeynet network launch.

We can eventually remove the static list from joeynet network.yml once Statistic service is up to date. Bootstrap supports both static and/or dynamic stats service lists.

fboucquez commented 2 years ago

Thanks @Jaguar0625 for the feedback,

joeynet is one of (potentially many) testnets. i don't think it makes sense to replace testnet with it. instead, i think we should drop testnet/mainnet entirely and just specify preset for mainnet/joeynet/etc.

I agree, I am working on all the toolings for multiple testnet support. The shared assemblies pr, the external network preset yml and seed for pr, symbol-network cli, the blog, etc.

Joeynet would be one of many, some official, some experimental (garsuh.dev), some community, etc.

I have asked if we should use the -p joeynet preset for this reset but we agreed to keep the -p testnet name.

https://discord.com/channels/856325968096133191/912347099155292163/912398258188484618

The current NGL testnet is reaching the EOL and we are not maintaining it anymore. It seems like Joeynet is becoming the principal testnet now. The -p testnet name is fine, we don't need to change the documentation around how to run a testnet node. We are also planning to reuse old testnet URLs like faucet, stats service, and explorer. If we keep both, we would need different URLs for Joeynet

i'd also suggest having a separate repo for the seed, so we can have releases for it similar to the release we have for mainnet seed: https://github.com/symbol/catapult-client/releases/download/v1.0.0.0/nemesis-seed.zip.

I like having the most common official networks seed and network.yml bundled in bootstrap. We don't need to maintain a separate hosting for the seeds and it's 'offline' friendly when generating the node configuration.

fboucquez commented 2 years ago

@Wayonb @Jaguar0625 , could we merge this one? it's blocking me for the testnet reset. Once I have this one I can create the new zips

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Wayonb commented 2 years ago

Create this issue to move the seed out of the bootstrap - https://github.com/symbol/symbol-bootstrap/issues/342