fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 27 forks source link

feat: Allowing user provided compose services via custom preset #345

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

This small feature allows users to tune the generated compose, for example adding a logger or third part compose service.

I would use this feature to inject AWS cloudwatch logging as Ravi requested.

Jaguar0625 commented 2 years ago

i still don't think this feature makes sense in bootstrap since the changes can be easily done as a post-build step. @gimre-xymcity and @0x6861746366574 can comment though.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fboucquez commented 2 years ago

i still don't think this feature makes sense in bootstrap since the changes can be easily done as a post-build step. @gimre-xymcity and @0x6861746366574 can comment though.

It's an optional feature to make it easier to extend compose. Post-build could be done but it would be harder for the end-user (or symbol-network) to parse and patch docker composes when it's created the first time and every time is --upgraded. I would definitely use an extension feature like this. The customization stays on the custom-preset.yml

A custom user post-build would modify the target folder which I prefer not to.

I have updated the test custom preset to add logging to each service.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication