fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 28 forks source link

fix: Account Resolver #350

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

fix: ConfigLoader split -> MigrationService, AddressesService, ConfigurationUtils fix: addresses.sinkAddress is not generated when it's not required

Note: I had to fix some imports. If not, oclif errors when generating the docs and the cli metadata. I think it's a circular dependency somewhere.

fboucquez commented 2 years ago

part 1, more tomorrow

Thanks gimre for the review. I'm trying to allow libs to provide their own accounts cached somewhere else, on-demand, when bootstrap requires it. I'm using this feature in symbol-network, when the keys are pre-created to generate the nemesis block. The feature is working, but the implementation is not great yet.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication